Set correct column types and full cell description for simple tables#119
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates the SimpleDataTableProvider to stop HTML-escaping table data, instead passing raw values via Simple-DataTables “cell objects” and explicitly setting column types so rendering and sorting behave correctly (and avoid HTML parsing errors).
Changes:
- Removed HTML-escaping for cell values/column names and adjusted unit tests accordingly.
- Updated the webview init script to provide per-cell
{ data, text, order }objects and to set an explicit sort/render type for every column. - Added custom
ordercomputation to enable correct sorting without relying on HTML parsing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/Client/tests/unit/dataTableProvider.test.ts | Updates expectations to reflect raw (non-HTML-escaped) payload and new script-escaping behavior. |
| src/Client/features/dataTableProvider.ts | Removes escapeHtml, builds explicit column settings, and passes cell objects + order values into Simple-DataTables. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.